Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CondaKernelSpecManager.env_filter regex #47

Merged
merged 1 commit into from
Oct 12, 2016

Conversation

parente
Copy link
Contributor

@parente parente commented Sep 13, 2016

In some deployments, there may be conda environments present that
should not appear in the list (e.g., environments that may have
jupyter, python, R but not kernels)

@coveralls
Copy link

coveralls commented Sep 13, 2016

Coverage Status

Coverage increased (+0.1%) to 74.17% when pulling 3c47982 on parente:env-filter into fa870f1 on Anaconda-Platform:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 74.17% when pulling 3c47982 on parente:env-filter into fa870f1 on Anaconda-Platform:master.

@ericdill
Copy link

@damianavila @bollwyvl any chance of reviewing this?

@damianavila
Copy link
Contributor

Sorry for the delay @ericdill and @parente... this is useful.
I like it, let's wait (for a little bit) for @bollwyvl 's look as well, otherwise I will merge it in a few days.

@bollwyvl
Copy link
Contributor

Yeah, looks good. Let's merge and move forward. I'll make some issues for some miscellany...

@bollwyvl bollwyvl merged commit 1b5b428 into anaconda:master Oct 12, 2016
@parente
Copy link
Contributor Author

parente commented Oct 12, 2016

Cool. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants