Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo functionality #74

Open
bollwyvl opened this issue May 26, 2016 · 2 comments
Open

Undo functionality #74

bollwyvl opened this issue May 26, 2016 · 2 comments

Comments

@bollwyvl
Copy link
Contributor

A number of users have complained of not having undo.

Baobabjs supports undo, so it should be relatively easy to add undo, though redo is harder.

Some research is needed to determine the different user activities that would would be undoable steps, as the atomic changes are too small for a user to usefully use.

@jbednar
Copy link

jbednar commented May 26, 2016

This is sorely needed before I would entrust a real project to nbpresent. Undo without redo is better than nothing, but still a bit scary, as it's then easy to accidentally undo important work and not be able to get it back. And I don't suppose redo can just be treated as undoing an undo, i.e. to save the state before undoing so that it can be restored after some other change?

@bollwyvl
Copy link
Contributor Author

Right, it's just not natively handled. Here's the (closed) issue. No new library has been forthcoming, but then, I haven't pushed on it either.

I can see a few ways to do it. The simplest is to indeed just have a series of snapshots, managed in another tree (or even something simpler), that I can whole-cloth drop onto the data-at-rest (what gets stored in the metadata).

Of course, I am not about to bite off global undo for the notebook, so it's certainly possible that one could undo to a state to where the notebook cells doesn't support what your slides expect. Luckily, for the most part, you probably just won't see some slide content, rather than anything breaking, as this is a state that a user could, themselves, get to.

@bollwyvl bollwyvl mentioned this issue Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants