Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History #76

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

History #76

wants to merge 4 commits into from

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jun 1, 2016

This adds a History view of your nbpresent content (e.g. slides and themes, not your notebook), constituting an initial stab at #74.

Here's a shot from the tests:
0037_fin

History goes back to your initial load from the server, the following activities are snapshotted/undoable:

  • Move/Resize Region
  • Nudge Region
  • Load from Server
  • Slide Layout
  • New Region
  • Set ${d.attr.key}
  • Set ${d.attr.key}
  • Set ${d.attr.key}
  • Reordered Slides
  • ${d.title()} Import
  • Set Slide Theme
  • Link Cell Part
  • Unlink Cell Part
  • Delete region
  • Add Slide
  • Remove Slide

There are some situations where a user could create an "unusable" history: the first time a cell's content is used, it is given an UUID. Going back in time will not unset that UUID or otherwise, but this seems like a pretty reasonable thing.

No history is ever culled (until you reload the browser) which might become an issue, as you can create some interesting timelines (which are always sorted by creation time). Often, behavior will be to remove "dead" branches, but in my local testing, I kind of liked being able to store multiple prior heads for looking at different approaches. Not to mention memory-leaky... worst-case scenario would be big images used as backgrounds, etc.

If you end up having to reload your page, then, you'll also lose history... but this seems not unreasonable.

I have also not added any keyboard shortcuts or additional buttons for undo/redo, as ctrl+z seems like a bad thing to take over.

@jbednar: is this starting to answer the mail on some of your concerns?

@coveralls
Copy link

coveralls commented Jun 1, 2016

Coverage Status

Coverage remained the same at 85.714% when pulling d882317 on history into 6bf2f50 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants