Fix fmcomms8 timing on zcu102 & adrv9009zu11eg #1079
+32
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrDragomir
force-pushed
the
fix_fmcomms8_timing
branch
3 times, most recently
from
03f2455
to
04cba86
Compare
AndrDragomir
force-pushed
the
fix_fmcomms8_timing
branch
from
04cba86
to
fd1f494
Compare
acostina
requested changes
Jun 4, 2024
| .spi_clk(spi_clk), | ||
| .spi_mosi(spi_mosi), | ||
| .spi_miso_i(spi_miso_s), | ||
| .spi_miso_o(spi0_miso), | ||
| .spi_miso(spi0_miso_3w), |
| ad_3w_spi #( | ||
| .NUM_OF_SLAVES(1) | ||
| ) i_spi ( | ||
| .spi_csn(spi_3_to_8_csn[2]), |
There was a problem hiding this comment.
adrv9009zu11eg_spi is implementing 3wire for spi_3_to_8_csn[2] and spi_3_to_8_csn[3], the replacement should do the same
| .spi_csn (spi_3_to_8_csn[2]), | ||
| .spi_clk (spi_clk), | ||
| .spi_mosi (spi_mosi), | ||
| .spi_miso (fmcomms8_miso_3w), |
There was a problem hiding this comment.
fmcomms8_miso_3w not defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fail is caused by SPI interface timing