Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cn0561: Fixed critical warning during make #1159

Merged
merged 1 commit into from
Aug 22, 2023
Merged

cn0561: Fixed critical warning during make #1159

merged 1 commit into from
Aug 22, 2023

Conversation

ladace
Copy link
Contributor

@ladace ladace commented Aug 17, 2023 •
edited
Loading

PR Description

The busy_sync pulse was replaced by an axi pwm generator IP, so the constraint in xdc file is no longer needed.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@ladace ladace added the bug label Aug 17, 2023
@ladace ladace requested a review from a team August 17, 2023 10:37
@IuliaCMoldovan
Copy link
Contributor

Please update the description (why this change/how does this solve the problem)

@IuliaCMoldovan IuliaCMoldovan mentioned this pull request Aug 17, 2023
Closed
12 tasks
@ladace
cn0561: Fixed critical warning during make
856b774 
The busy_sync pulse was replaced by an axi pwm generator IP, so the
constraint in xdc file is no longer needed.
@ladace
Copy link
Contributor Author

ladace commented Aug 21, 2023

[V1]

  • fixed commit message

@ladace
Copy link
Contributor Author

ladace commented Aug 21, 2023

Please update the description (why this change/how does this solve the problem)

Fixed the commit message

@ladace ladace self-assigned this Aug 21, 2023
laurent-19
laurent-19 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@laurent-19 laurent-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, not longer needing that, same has done for the zed project xdc.

@ladace ladace merged commit ae09b8a into master Aug 22, 2023
1 of 2 checks passed
@ladace ladace deleted the dev_cn0561_CW branch August 22, 2023 09:17
ladace added a commit that referenced this pull request Sep 25, 2023
@ladace
cn0561: Fixed critical warning during make (#1159)
dc696ff 
The busy_sync pulse was replaced by an axi pwm generator IP, so the
constraint in xdc file is no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurent-19 laurent-19 laurent-19 approved these changes

@PopPaul2021 PopPaul2021 Awaiting requested review from PopPaul2021

Assignees

@ladace ladace

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ladace @IuliaCMoldovan @laurent-19