Merge travis branch #2 #69
Conversation
| @@ -262,6 +262,26 @@ endif() | |||
| #set(SETUP_PY ${CMAKE_CURRENT_SOURCE_DIR}/bindings/python/setup.py) | |||
| #configure_file(python/setup.py.in ${SETUP_PY} @ONLY) | |||
|
|
|||
| # support creating some basic binpkgs via `make package` | |||
| set(LIBIIO_VERSION_PATCH ${LIBIIO_VERSION_GIT}) | |||
There was a problem hiding this comment.
Use g${LIBIIO_VERSION_GIT}
With the small 'g' before, it's the convention when git tags are used in versions.
Also instead of defining LIBIIO_VERSION_PATCH you could just set that line 277.
| - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install --build-from-source libusb; fi | ||
| - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then sudo apt-get -qq update ; fi | ||
| - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then sudo apt-get install -y doxygen; fi | ||
| - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then sudo apt-get install -y libaio-dev; fi |
There was a problem hiding this comment.
Maybe install all those packages in one apt-get install line, that would shrink the patch.
There was a problem hiding this comment.
I could do that - but found it easier to debug with every line installing one thing. I know it looks kind of fugly- but there are limits in yaml (no multi-line), that cause issues as well. I would prefer to leave it - unless you feel strongly about it.
| - PKG_RULE=gzip | ||
| - COVERITY_SCAN_PROJECT_NAME="$TRAVIS_REPO_SLUG" | ||
| - COVERITY_SCAN_BRANCH_PATTERN="travis-ci" | ||
| - COVERITY_SCAN_NOTIFICATION_EMAIL="robin.getz@analog.com" |
There was a problem hiding this comment.
Is that the email address used when new bugs are found? Maybe we should be in there as well.
There was a problem hiding this comment.
No, it's an email every time it runs with the results. (Did you still want to be there?)
Signed-off-by: Robin Getz <robin.getz@analog.com>
coverity, to make sure things are A-OK. Also turn on all the backends, to make sure we test all the code paths. Signed-off-by: Robin Getz <robin.getz@analog.com>
can quickly see status. Signed-off-by: Robin Getz <robin.getz@analog.com>
|
Updated - let me know if that works. -Robin |
|
Merged. Thanks! |
Update the CMake, so we build nightly debs & rpms, and set up things for coverity with travis.
-Robin