-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iio: gyro: adxrs290: Add triggered buffer support #1131
Merged
commodo
merged 5 commits into
analogdevicesinc:gsoc2020-gyro
from
layman-n-ish:rpi-4.19.y_adxrs290
Aug 25, 2020
Merged
iio: gyro: adxrs290: Add triggered buffer support #1131
commodo
merged 5 commits into
analogdevicesinc:gsoc2020-gyro
from
layman-n-ish:rpi-4.19.y_adxrs290
Aug 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layman-n-ish
force-pushed
the
rpi-4.19.y_adxrs290
branch
2 times, most recently
from
August 19, 2020 18:41
5651375
to
c1864e2
Compare
commodo
reviewed
Aug 20, 2020
commodo
reviewed
Aug 20, 2020
commodo
reviewed
Aug 20, 2020
commodo
reviewed
Aug 20, 2020
commodo
reviewed
Aug 20, 2020
commodo
reviewed
Aug 20, 2020
commodo
reviewed
Aug 20, 2020
commodo
reviewed
Aug 20, 2020
rest looks good |
Insert a missing mutex_init() call during the probe that initializes the driver's local lock to unlocked state. Fixes: ac98be7 ("iio: gyro: Update ADXRS290 driver for channels support") Signed-off-by: Nishant Malpani <nish.malpani25@gmail.com>
Provide a way for continuous data capture by setting up buffer support. The data ready signal exposed at the SYNC pin of the ADXRS290 is exploited as a hardware interrupt which triggers to fill the buffer. Triggered buffer setup was tested with both hardware trigger (DATA_RDY) and software triggers (sysfs-trig & hrtimer). Signed-off-by: Nishant Malpani <nish.malpani25@gmail.com>
Configure ADXRS290 to use a GPIO interrupt line as a DATA_RDY trigger signal. Signed-off-by: Nishant Malpani <nish.malpani25@gmail.com>
Append 'interrupts' as a required property and provide a suitable example for using a GPIO interrupt line. Signed-off-by: Nishant Malpani <nish.malpani25@gmail.com>
Extend support to read/write byte data from/to the device using debugfs iio interface. Signed-off-by: Nishant Malpani <nish.malpani25@gmail.com>
layman-n-ish
force-pushed
the
rpi-4.19.y_adxrs290
branch
from
August 21, 2020 08:17
c1864e2
to
b350993
Compare
Changelog v2:
|
dbogdan
approved these changes
Aug 24, 2020
commodo
reviewed
Aug 25, 2020
@@ -385,6 +385,8 @@ static int adxrs290_probe(struct spi_device *spi) | |||
indio_dev->num_channels = ARRAY_SIZE(adxrs290_channels); | |||
indio_dev->info = &adxrs290_info; | |||
|
|||
mutex_init(&st->lock); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when sending this upstream, the commit has for the Fixes tag should be the one in the upstream tree;
otherwise this is perfect as-is
commodo
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a way for continuous data capture by setting up buffer support. The
data ready signal exposed at the SYNC pin of the ADXRS290 is exploited as
a hardware interrupt which triggers to fill the buffer.
Triggered buffer setup was tested with both hardware trigger (DATA_RDY) and
software triggers (sysfs-trig & hrtimer).
Also, extend support to read/write byte data from/to the device using
debugfs interface.
Signed-off-by: Nishant Malpani nish.malpani25@gmail.com