-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(BLE): Re-implement UART with DMA on MAX32690 #1280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix/me18-uart-dma
crsz20
added
WIP
work in progress
MAX32690
Related to the MAX32690 (ME18)
BLE
Related to Bluetooth
labels
Nov 26, 2024
/clang-format-run |
Remove the PAL_UART Example |
EricB-ADI
approved these changes
Dec 9, 2024
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initializing a UART peripheral with
MXC_UART_IBRO_CLK
would cause the MAX32690 to occasionally fail to assert a half-empty interrupt signal. This is a hardware issue.In practice, this causes the Tx buffer to get stuck and eventually overflows. This is evident in the BLE examples with a large amount of serial output.
Solution
This device's
pal_uart.c
in Cordio has been re-implemented with DMA to rely on other interrupt signals to handle buffer management more reliably.Remarks
Eric added a PAL_UART example to help test echoing in the serial output.