fix(PeriphDrivers): Fix SPI pins and peripheral clock for MAX32657 #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use correct pin numbers when initializing SPI on MAX32657. Signed-off-by: Tahsin Mutlugun <Tahsin.Mutlugun@analog.com>
MAX32657 SPI input clock rate should be APB clock divided by two. Signed-off-by: Tahsin Mutlugun <Tahsin.Mutlugun@analog.com>
ttmut
changed the title
ozersa
approved these changes
Dec 16, 2024
sihyung-maxim
approved these changes
Dec 16, 2024
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes following changes to MAX32657 SPI driver.
Configure correct pins during MAX32657 SPI initialization.
Use correct peripheral clock rate.
Input clock for MAX32657 SPI should be APB / 2. Otherwise we get half of the calculated frequency on the SCK pin.