feat(CMSIS,PeriphDrivers): Enable external clock selection on MAX32657 #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that external clock selection bits are defined, uncomment code to allow external clock to be used. Signed-off-by: Tahsin Mutlugun <Tahsin.Mutlugun@analog.com>
Update the code to use the correct clock rate of 131kHz for internal nano-ring oscillator. Signed-off-by: Tahsin Mutlugun <Tahsin.Mutlugun@analog.com>
ttmut
force-pushed
the
fix/me30_clock
branch
from
a7e1974 to
bc515f2
Compare
| @@ -38,7 +38,7 @@ extern "C" { | |||
| Update if use of this oscillator requires precise timing.*/ | |||
| /* NOTE: INRO was previously named NANORING */ | |||
| #ifndef INRO_FREQ | |||
| #define INRO_FREQ 100000 | |||
| #define INRO_FREQ 131000 | |||
There was a problem hiding this comment.
Is this the nominal value that's indicated in the datasheet? The INRO frequency is highly variable which could be 131KHz on one part or 80KHz on another.
There was a problem hiding this comment.
Yes, it is given as 131kHz in both the user guide and the datasheet for MAX32657, if that is what you mean.
sihyung-maxim
approved these changes
Dec 16, 2024
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uncomment clock selection code to allow external clock input to be used as system clock since external clock pin and system clock selection bits are now known.
Set INRO clock frequency to 131kHz.