Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Documentation): Fix Incorrect README Instructions for CLI Repo Setup #700

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

Jake-Carter
Copy link
Contributor

@Jake-Carter Jake-Carter commented Aug 7, 2023

Pull Request Template

Description

As pointed out in analogdevicesinc/MAX78xxx-RefDes#50, modifying msys.bat is not the right way to change MAXIM_PATH on windows. setenv.bat should be used instead.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

Copy link
Contributor

@sihyung-maxim sihyung-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this change causes the AI85 RV_ARM_Loader example to fail to build...

@Jake-Carter
Copy link
Contributor Author

Not sure how this change causes the AI85 RV_ARM_Loader example to fail to build...

Ghosts in the machine... re-running the workflow passed

@Jake-Carter Jake-Carter merged commit b164f87 into analogdevicesinc:main Aug 8, 2023
13 of 14 checks passed
@Jake-Carter Jake-Carter deleted the fix/readme branch August 8, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants