Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): honour user's test.pool choice #1080

Merged
merged 1 commit into from
May 3, 2024

Conversation

yjaaidi
Copy link
Contributor

@yjaaidi yjaaidi commented May 3, 2024

Do not override test.pool option if it is already set by the user.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #937

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

do not override test.pool option if it is already set by the user
Copy link

netlify bot commented May 3, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 397db13
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/66351241321be50008c55d87
😎 Deploy Preview https://deploy-preview-1080--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 3, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 397db13
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/66351241e863740008c0c64d
😎 Deploy Preview https://deploy-preview-1080--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 3, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 397db13
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/663512419a365e000877700a
😎 Deploy Preview https://deploy-preview-1080--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 3, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 397db13
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/663512419a365e000877700c
😎 Deploy Preview https://deploy-preview-1080--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts changed the title feat(vite-plugin-angular): honour user's test.pool choice fix(vite-plugin-angular): honour user's test.pool choice May 3, 2024
Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@brandonroberts brandonroberts merged commit b3d27eb into analogjs:beta May 3, 2024
24 checks passed
@brandonroberts
Copy link
Member

Awesome, thanks! @allcontributors add @yjaaidi for code, test

Copy link
Contributor

@brandonroberts

I've put up a pull request to add @yjaaidi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding vitest pool
2 participants