Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): adjust peer dependencies meta for different highlighters #1124

Merged

Conversation

nartc
Copy link
Member

@nartc nartc commented May 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • vitest-angular
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Dependency errors on missing peer dependencies of unused highlighters.

What is the new behavior?

Should not have dependency errors on missing peer dependencies of unused highlighters.

mermaid is also removed from the @analogjs/content peer dependencies because it is not a peer dependency.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented May 29, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 48799f1
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/665739826e35cc00083d7fdf
😎 Deploy Preview https://deploy-preview-1124--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 29, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 48799f1
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/665739821414250008af3c23
😎 Deploy Preview https://deploy-preview-1124--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 29, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 48799f1
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/66573982ff2dfd0008d6bcd5
😎 Deploy Preview https://deploy-preview-1124--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 29, 2024

Deploy Preview for analog-ng-app failed.

Name Link
🔨 Latest commit 48799f1
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/665739823b5cca00085d01af

@nartc nartc force-pushed the chore/make-highlighting-peer-deps-optional branch from 7b0254d to 48799f1 Compare May 29, 2024 14:19
@nartc nartc self-assigned this May 29, 2024
@nartc nartc added the bug Something isn't working label May 29, 2024
@nartc nartc requested a review from brandonroberts May 29, 2024 14:24
@brandonroberts brandonroberts merged commit 5708d7d into analogjs:beta May 29, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants