Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): resolve JIT external template/style files #1493

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

brandonroberts
Copy link
Member

PR Checklist

Closes #1288

What is the new behavior?

External templates and styles are resolved correctly when the vite plugin is registered multiple times, using a combination of JIT being enabled and disabled.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit b313f92
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/675995e6bc6d2f000891ab90
😎 Deploy Preview https://deploy-preview-1493--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit b313f92
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/675995e67abc7f0008c6afa5
😎 Deploy Preview https://deploy-preview-1493--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit b313f92
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/675995e6cb264c0008472ff3
😎 Deploy Preview https://deploy-preview-1493--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit b313f92
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/675995e6aba39f000855f119
😎 Deploy Preview https://deploy-preview-1493--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 54e9488 into beta Dec 11, 2024
22 of 24 checks passed
@brandonroberts brandonroberts deleted the fix-jit-resolve branch December 11, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant