fix(router): properly parse json response in the FormAction #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks @milosdanilov, the fix looks good. We already have a Would you revert the changes to the cart and update that one instead? |
|
@brandonroberts Sure, will do |
milosdanilov
force-pushed
the
fix/form-action-json-response
branch
from
4c703fb to
a2c2f60
Compare
milosdanilov
force-pushed
the
fix/form-action-json-response
branch
from
a2c2f60 to
b5ee12b
Compare
milosdanilov
force-pushed
the
fix/form-action-json-response
branch
from
b5ee12b to
62f94fc
Compare
brandonroberts
approved these changes
Feb 12, 2025
|
Thanks! @allcontributors add @milosdanilov for code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Fixes the parsing of a JSON response created using the form server actions, used by the FormAction directive.
The problem arose because the
jsonfunction, on the server, sets the Content-Type header toapplication/json; charset=utf-8(see this line). The additionalcharset=utf-8parameter caused the content-type check to fail, treating the response as plain text. As a result, the response was incorrectly parsed as text instead of JSON.What is the new behavior?
This change ensures the response is correctly handled as JSON, even when the
charset=utf-8parameter is present in the Content-Type header.Does this PR introduce a breaking change?
Other information
The newsletter.page example in the analog-app is updated to show the email from the response, and additional cypress tests for newsletter page for this case are written.