fix(router): server-side-data-fetching when using basehref #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
url.pathname ignoring path defined in env flag: VITE_ANALOG_PUBLIC_BASE_URL. fixes: analogjs#954
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonroberts
requested changes
Apr 4, 2024
Co-authored-by: Brandon Roberts <robertsbt@gmail.com>
Co-authored-by: Brandon Roberts <robertsbt@gmail.com>
Co-authored-by: Brandon Roberts <robertsbt@gmail.com>
Co-authored-by: Brandon Roberts <robertsbt@gmail.com>
brandonroberts
approved these changes
Apr 4, 2024
|
Thanks! @allcontributors add @leblancmeneses for code, doc |
|
I've put up a pull request to add @leblancmeneses! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url.pathname ignoring path defined in env flag: VITE_ANALOG_PUBLIC_BASE_URL.
fixes: #954
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Closes #954
What is the new behavior?
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?