Skip to content

Commit

Permalink
Remove deprecated service.py usages from test
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 668137152
  • Loading branch information
anandolee authored and copybara-github committed Aug 27, 2024
1 parent 92f979b commit 471ff77
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 15 deletions.
7 changes: 0 additions & 7 deletions python/google/protobuf/internal/generator_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import unittest

from google.protobuf.internal import test_bad_identifiers_pb2
from google.protobuf import service
from google.protobuf import symbol_database
from google.protobuf import unittest_import_pb2
from google.protobuf import unittest_import_public_pb2
Expand Down Expand Up @@ -283,12 +282,6 @@ def testNoGenericServices(self):
self.assertTrue(hasattr(unittest_no_generic_services_pb2, "FOO"))
self.assertTrue(hasattr(unittest_no_generic_services_pb2, "test_extension"))

# Make sure unittest_no_generic_services_pb2 has no services subclassing
# Proto2 Service class.
if hasattr(unittest_no_generic_services_pb2, "TestService"):
self.assertFalse(issubclass(unittest_no_generic_services_pb2.TestService,
service.Service))

def testMessageTypesByName(self):
file_type = unittest_pb2.DESCRIPTOR
self.assertEqual(
Expand Down
9 changes: 5 additions & 4 deletions python/google/protobuf/internal/service_reflection_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,21 @@
import unittest

from google.protobuf import service_reflection
from google.protobuf import service
from google.protobuf import unittest_pb2


class FooUnitTest(unittest.TestCase):

def testService(self):
class MockRpcChannel(service.RpcChannel):

class MockRpcChannel:
def CallMethod(self, method, controller, request, response, callback):
self.method = method
self.controller = controller
self.request = request
callback(response)

class MockRpcController(service.RpcController):
class MockRpcController:
def SetFailed(self, msg):
self.failure_message = msg

Expand Down Expand Up @@ -81,7 +81,8 @@ def Bar(self, rpc_controller, request, done):
self.assertEqual(True, srvc.bar_called)

def testServiceStub(self):
class MockRpcChannel(service.RpcChannel):

class MockRpcChannel:
def CallMethod(self, method, controller, request,
response_class, callback):
self.method = method
Expand Down
8 changes: 4 additions & 4 deletions python/google/protobuf/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,12 @@ def CallMethod(self, method_descriptor, rpc_controller,
Postconditions:
* "done" will be called when the method is complete. This may be
before CallMethod() returns or it may be at some point in the future.
before CallMethod() returns or it may be at some point in the future.
* If the RPC failed, the response value passed to "done" will be None.
Further details about the failure can be found by querying the
RpcController.
Further details about the failure can be found by querying the
RpcController.
"""
raise NotImplementedError
raise NotImplementedError

def GetRequestClass(self, method_descriptor):
"""Returns the class of the request message for the specified method.
Expand Down

0 comments on commit 471ff77

Please sign in to comment.