Skip to content

Commit

Permalink
fix(DoIUse): support string constructor argument
Browse files Browse the repository at this point in the history
Interpret string options as shorthand for browser option.

This was supported before the move to ESM.
  • Loading branch information
clshortfuse committed Jul 4, 2023
1 parent bb192ec commit ab7df2f
Showing 1 changed file with 17 additions and 10 deletions.
27 changes: 17 additions & 10 deletions lib/DoIUse.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,24 @@ import Detector from './Detector.js';
* @return {any}
*/

/**
* @typedef {Object} DoIUseOptions
* @prop {ConstructorParameters<typeof BrowserSelection>[0]} [browsers]
* @prop {FeatureKeys[]} [ignore]
* @prop {OnFeatureUsage} [onFeatureUsage]
* @prop {string[]} [ignoreFiles]
*/

export default class DoIUse {
static default = null;

/**
* @param {Object} [options]
* @param {ConstructorParameters<typeof BrowserSelection>[0]} [options.browsers]
* @param {FeatureKeys[]} [options.ignore]
* @param {OnFeatureUsage} [options.onFeatureUsage]
* @param {string[]} [options.ignoreFiles]
* @param {DoIUseOptions} [optionsOrBrowserQuery]
*/
constructor(options = {}) {
constructor(optionsOrBrowserQuery) {
const options = (typeof optionsOrBrowserQuery === 'string')
? { browsers: optionsOrBrowserQuery }
: { ...optionsOrBrowserQuery };
this.browserQuery = options.browsers;
this.onFeatureUsage = options.onFeatureUsage;
this.ignoreOptions = options.ignore;
Expand All @@ -39,11 +46,11 @@ export default class DoIUse {
}

/**
* @param {Object} [opts]
* @param {ConstructorParameters<typeof BrowserSelection>[1]} [opts.from]
* @param {Object} [options]
* @param {ConstructorParameters<typeof BrowserSelection>[1]} [options.from]
*/
info(opts = {}) {
const { browsers, features } = BrowserSelection.missingSupport(this.browserQuery, opts.from);
info(options = {}) {
const { browsers, features } = BrowserSelection.missingSupport(this.browserQuery, options.from);

return {
browsers,
Expand Down

0 comments on commit ab7df2f

Please sign in to comment.