Changing initialization of max_batch_size
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior: if None or greater than the dataset length, it is set to the dataset length Current behavior: If None, it is set to the dataset length + 1, if the dataset has a length. Otherwise, it is set to 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior: If
max_batch_sizeisNoneor greater than the dataset length, it is set to the dataset length.Current behavior: If
max_batch_sizeisNone, it is set to the dataset length + 1, if the dataset has a length. Otherwise, it is set to 1.This fixes the case in which the dataset does not have a length available, or when the length of the dataset is dynamic and can be changed by the user.