Skip to content

Commit

Permalink
https: support agent construction without new
Browse files Browse the repository at this point in the history
Fixes: nodejs#12918
PR-URL: nodejs#12927
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
cjihrig authored and Olivier Martin committed May 19, 2017
1 parent b7cfca7 commit 47c4d96
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/https.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ function createConnection(port, host, options) {


function Agent(options) {
if (!(this instanceof Agent))
return new Agent(options);

http.Agent.call(this, options);
this.defaultPort = 443;
this.protocol = 'https:';
Expand Down
7 changes: 7 additions & 0 deletions test/parallel/test-https-agent-constructor.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
'use strict';
require('../common');
const assert = require('assert');
const https = require('https');

assert.doesNotThrow(() => { https.Agent(); });
assert.ok(https.Agent() instanceof https.Agent);

0 comments on commit 47c4d96

Please sign in to comment.