Additional ecosystem related v6 fixes #2450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several adjustments related to ecosystem (and related) searches based on initial v6 testing:
vx.VulnerabilityProvider
with a newPackageSearchNames
method on the interface.search.ByLanguage
to besearch.ByEcosystem
, taking both language and package type. This allows v5 to continue using language as the primary way to search while allowing v6 to move towards searching by package type (which is what the DB v6 schema ecosystem column orients around)MimicV5Namespace
VulnerabilityHandle
to already exist on vuln reference objects when using fetchingVulnerabilityMetadata
via theVulnerabilityProvider
. Not all uses of this function have already populated internal instances (such as with related vulnerabilities within the nvd namespace). This now optionally usesGetVulnerabilities
on theVulnerabilityStore
in such cases.VulnerabilityHandles
table, speeding upVulnerabilityMetadata
calls a lot.