-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: track script to make local test images #476
base: main
Are you sure you want to change the base?
Conversation
this would require that local development requires non local resources for testing, which isn't ideal
yes -- I think the idiomatic way to deal with stuff like this is as a new script entry here Line 7 in 72370e1
can it be both? That is, have the test automatically set it up if its not already running, or use an already running one?
My vote would be to name it |
Questions:
This should be integrated into the tests so running
No, it should be integrated with the tests.
Fail the tests.
This would be a fine solution, too -- it could be a GHCR package linked to this repo. |
It sounds like consensus is to move startup code from sbom-action/.github/workflows/test.yml Lines 68 to 73 in 72370e1
to a target in Line 7 in 72370e1
It might be nice to go further and make
Therefore, for I'll see how hard it is to make an |
These images are not really ever changing, the main purpose was just to validate that the command is actually running and generating files and that the output isn't changing drastically. I strongly favor just pushing these images to GHCR and updating the tests to point to them. |
Can be used for local development. Might be worth integrating into npm commands. Signed-off-by: Will Murphy <will.murphy@anchore.com>
02ff94f
to
41a9612
Compare
Can be used for local development. Might be worth integrating into npm commands.
Remembering to start the local registry before running tests locally is cumbersome. Here's a shell script, copied essential from the docs, to do it for us.
Questions:
registry
or a port is in use?PR is a conversation starter, in other words. But this script has been kicking around locally for a while and I use it, so I wanted to share.