fix: download grype on windows runners #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <kzantow@gmail.com>
kzantow
force-pushed
the
fix/execute-on-windows
branch
from
9ade014
to
b13c331
Compare
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
willmurphyscode
previously approved these changes
May 17, 2024
Signed-off-by: Keith Zantow <kzantow@gmail.com>
kzantow
force-pushed
the
fix/execute-on-windows
branch
from
00ce720
to
e0a00e3
Compare
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
.github/workflows/test.yml
Outdated
| fail-build: false | ||
|
|
||
| - name: Validate file exists | ||
| run: ls '${{ steps.scan.outputs.sarif }}' |
There was a problem hiding this comment.
I had to double-check up the return code of ls if passed a non-existent file. On Linux, I think test -f might be a cleaner test (though test isn't available on Windows).
Not blocking though - this works.
.github/workflows/test.yml
Outdated
| fail-build: false | ||
|
|
||
| - name: Validate file exists | ||
| run: ls '${{ steps.scan.outputs.sarif }}' |
There was a problem hiding this comment.
Just want to double-check that this way of checking whether a file exists works on Windows - don't have a windows machine in front of me to check myself.
Specifically, can you make sure that ls some-non-existent-file on Windows exits non-zero?
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
kzantow
force-pushed
the
fix/execute-on-windows
branch
from
42c30ab
to
ff87f3f
Compare
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
willmurphyscode
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running this action on Windows, we need to account for the
.exefile suffix.Fixes: #313