Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Include version information in binary cataloger CPEs #1310

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Fix: Include version information in binary cataloger CPEs #1310

merged 1 commit into from
Nov 3, 2022

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Nov 2, 2022

This PR corrects an issue where the node binary cataloger was outputting a CPE without version information.

Before:

"cpes": [
    "cpe:2.3:a:nodejs:node.js:*:*:*:*:*:*:*:*",
    "cpe:2.3:a:node:node:19.0.0:*:*:*:*:*:*:*",
    "cpe:2.3:a:*:node:19.0.0:*:*:*:*:*:*:*"
   ],

After:

"cpes": [
    "cpe:2.3:a:nodejs:node.js:19.0.0:*:*:*:*:*:*:*",
    "cpe:2.3:a:node:node:19.0.0:*:*:*:*:*:*:*",
    "cpe:2.3:a:*:node:19.0.0:*:*:*:*:*:*:*"
   ],

@kzantow
fix: include version information in binary cataloger CPEs
1953b12 
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow requested a review from a team November 2, 2022 18:47
@spiffcs spiffcs changed the title Include version information in binary cataloger CPEs Fix: Include version information in binary cataloger CPEs Nov 3, 2022
@spiffcs spiffcs merged commit 3e99c4d into anchore:main Nov 3, 2022
@kzantow kzantow deleted the fix/include-binary-cataloger-cpe-version branch November 3, 2022 14:22
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@kzantow
Fix: Include version information in binary cataloger CPEs (anchore#1310)
925963e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffcs spiffcs spiffcs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kzantow @spiffcs