Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SBOM conversions from STDIN #1570

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Enable SBOM conversions from STDIN #1570

merged 1 commit into from
Feb 14, 2023

Conversation

wagoodman
Copy link
Contributor

A small addition to the convert command to allow for taking SBOMs from stdin:

cat my.sbom | syft convert - -o spdx-json

@wagoodman
allow convert to take stdin
0166c4b 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman added the enhancement New feature or request label Feb 14, 2023
@wagoodman wagoodman requested a review from a team February 14, 2023 14:55
@wagoodman wagoodman enabled auto-merge (squash) February 14, 2023 14:55
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
goos: linux
goarch: amd64
pkg: github.com/anchore/syft/test/integration
cpu: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
                                                          │ ./.tmp/benchmark-0929256.txt │
                                                          │            sec/op            │
ImagePackageCatalogers/alpmdb-cataloger-2                                   12.37m ±  2%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             908.9µ ± 11%
ImagePackageCatalogers/python-package-cataloger-2                           3.095m ±  2%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   707.9µ ±  1%
ImagePackageCatalogers/javascript-package-cataloger-2                       379.2µ ±  1%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   526.6µ ±  2%
ImagePackageCatalogers/rpm-db-cataloger-2                                   515.8µ ±  1%
ImagePackageCatalogers/java-cataloger-2                                     11.16m ±  1%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     8.943µ ±  2%
ImagePackageCatalogers/apkdb-cataloger-2                                    522.3µ ±  1%
ImagePackageCatalogers/go-module-binary-cataloger-2                         19.17µ ±  1%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              1.005m ±  1%
ImagePackageCatalogers/portage-cataloger-2                                  332.1µ ±  2%
ImagePackageCatalogers/sbom-cataloger-2                                     107.2µ ±  0%
ImagePackageCatalogers/binary-cataloger-2                                   141.4µ ±  0%
geomean                                                                     471.9µ

                                                          │ ./.tmp/benchmark-0929256.txt │
                                                          │             B/op             │
ImagePackageCatalogers/alpmdb-cataloger-2                                   5.060Mi ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             141.8Ki ± 0%
ImagePackageCatalogers/python-package-cataloger-2                           947.1Ki ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   155.9Ki ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                       95.56Ki ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   144.6Ki ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                   170.3Ki ± 0%
ImagePackageCatalogers/java-cataloger-2                                     2.721Mi ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     1.523Ki ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                    123.0Ki ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                         3.102Ki ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              314.7Ki ± 0%
ImagePackageCatalogers/portage-cataloger-2                                  75.44Ki ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                     13.04Ki ± 0%
ImagePackageCatalogers/binary-cataloger-2                                   20.53Ki ± 0%
geomean                                                                     106.6Ki

                                                          │ ./.tmp/benchmark-0929256.txt │
                                                          │          allocs/op           │
ImagePackageCatalogers/alpmdb-cataloger-2                                    86.71k ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                              2.159k ± 0%
ImagePackageCatalogers/python-package-cataloger-2                            15.49k ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                    3.458k ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                        1.252k ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                    2.646k ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                    3.759k ± 0%
ImagePackageCatalogers/java-cataloger-2                                      38.26k ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                       40.00 ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                     3.251k ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                           101.0 ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                               5.011k ± 0%
ImagePackageCatalogers/portage-cataloger-2                                   1.487k ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                       392.0 ± 0%
ImagePackageCatalogers/binary-cataloger-2                                     609.0 ± 0%
geomean                                                                      2.170k

kzantow
kzantow approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wagoodman wagoodman merged commit 9b9a7d6 into main Feb 14, 2023
@wagoodman wagoodman deleted the add-convert-from-stdin branch February 14, 2023 15:03
This was referenced Feb 16, 2023
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 24, 2023
Closed
Closed
Closed
Closed
Closed
Closed
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
allow convert to take stdin (anchore#1570)
64159da 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagoodman @kzantow