Translate maps to sequences in package metadata #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
json-schema
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
wagoodman
force-pushed
the
translate-maps-to-sequences
branch
from
835374f to
7c0f337
Compare
spiffcs
approved these changes
Jan 31, 2024
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple map collections on package metadata that originate from sequential entries. This means that the original order of how the data is written and read is lost, which could lead to semantic differences. This PR updates these inconsistent fields to use a new
[]pkg.KeyValueto express these collections, preserving the order of the values from the source file read.Fields updated:
ConanLockEntry.OptionsGolangBinaryBuildinfoEntry.BuildSettingsJavaPomProperties.ExtraJavaManifest(all of it)LinuxKernelModule.ParametersPhpComposerLockEntry, fieldsRequire,Provide,RequireDev,SuggestNote: since this updates the package metadata it requires a breaking JSON schema change.
Fixes #2405