keira: nesapp: fix string going out of scope before nofrendo starts

and3rson · Apr 14, 2024 · 8748834 · 8748834
1 parent b3603fe
commit 8748834
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/firmware/keira/src/apps/nes/nesapp.cpp b/firmware/keira/src/apps/nes/nesapp.cpp
@@ -2,10 +2,15 @@
 #include "driver.h"
 
 NesApp::NesApp(String path) : App("NES", 0, 0, lilka::display.width(), lilka::display.height()) {
-    argv[0] = const_cast<char*>(path.c_str());
+    argv[0] = new char[path.length() + 1];
+    strcpy(argv[0], path.c_str());
     setFlags(AppFlags::APP_FLAG_FULLSCREEN);
 }
 
+NesApp::~NesApp() {
+    delete[] argv[0];
+}
+
 void NesApp::run() {
     // Load the ROM
     Driver::setNesApp(this);

diff --git a/firmware/keira/src/apps/nes/nesapp.h b/firmware/keira/src/apps/nes/nesapp.h
@@ -4,6 +4,7 @@
 class NesApp : public App {
 public:
     explicit NesApp(String path);
+    ~NesApp();
 
 private:
     void run();