fix cppcheck errors

and3rson · Jun 7, 2024 · c7c8583 · c7c8583
1 parent f9a4f98
commit c7c8583
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/firmware/keira/src/utils/combo/concurrent_buttons.cpp b/firmware/keira/src/utils/combo/concurrent_buttons.cpp
@@ -36,7 +36,7 @@ void ComboConcurrentButtons::loopAction(State& state) {
     if (buttonStage.isReleased()) {
         return;
     }
-    _StateButtons& buttonStates = *reinterpret_cast<_StateButtons*>(&state);
+    const _StateButtons& buttonStates = *reinterpret_cast<const _StateButtons*>(&state);
     switch (buttonStage.getStage()) {
         case WAITING:
             checkAllButtonsPressed(buttonStates);

diff --git a/firmware/keira/src/utils/combo/one_button.cpp b/firmware/keira/src/utils/combo/one_button.cpp
@@ -19,8 +19,8 @@ void ComboOneButton::loopAction(State& state) {
     if (buttonStage.isReleased()) {
         return;
     }
-    _StateButtons& buttonStates = *reinterpret_cast<_StateButtons*>(&state);
-    ButtonState& bs = buttonStates[buttonStage.getButton()];
+    const _StateButtons& buttonStates = *reinterpret_cast<const _StateButtons*>(&state);
+    const ButtonState& bs = buttonStates[buttonStage.getButton()];
     switch (buttonStage.getStage()) {
         case WAITING:
             if (bs.justPressed) {

diff --git a/firmware/keira/src/utils/combo/one_hold_down_button.cpp b/firmware/keira/src/utils/combo/one_hold_down_button.cpp
@@ -39,14 +39,14 @@ void ComboOneHoldDownButton::loopAction(State& state) {
     if (buttonStage.isReleased()) {
         return;
     }
-    _StateButtons& buttonStates = *reinterpret_cast<_StateButtons*>(&state);
+    const _StateButtons& buttonStates = *reinterpret_cast<const _StateButtons*>(&state);
     if (checkNonTargetButtons && buttonStage.isPressed() && !isCompleted() &&
         isNonTargetButtonPressed(buttonStage.getButton(), buttonStates)) {
         resetAction();
         onReset();
         return;
     }
-    ButtonState& bs = buttonStates[buttonStage.getButton()];
+    const ButtonState& bs = buttonStates[buttonStage.getButton()];
     switch (buttonStage.getStage()) {
         case WAITING:
             if (bs.justPressed) {

diff --git a/firmware/keira/src/utils/combo/sequence_buttons.cpp b/firmware/keira/src/utils/combo/sequence_buttons.cpp
@@ -41,7 +41,7 @@ void ComboButtonSequence::loopAction(State& state) {
     if (areAllButtonsProcessed()) {
         return;
     }
-    _StateButtons& buttonStates = *reinterpret_cast<_StateButtons*>(&state);
+    const _StateButtons& buttonStates = *reinterpret_cast<const _StateButtons*>(&state);
     if (firstComboButtonAlreadyPressed && !isCompleted()) {
         if (buttonStage.isWaiting() && isTimeout(buttonStage.getPrevReleaseTime()) ||
             buttonStage.isPressed() && isTimeout(buttonStage.getPressTime()) ||
@@ -52,7 +52,7 @@ void ComboButtonSequence::loopAction(State& state) {
         }
     }
 
-    ButtonState& bs = buttonStates[buttonStage.getButton()];
+    const ButtonState& bs = buttonStates[buttonStage.getButton()];
     switch (buttonStage.getStage()) {
         case WAITING:
             if (bs.justPressed) {