#167294842:fix noko project tag not showing #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fill-up the empty spaces with N/A for missing projects. [starts: #167294842]
09arnold
reviewed
Aug 20, 2019
| @@ -168,14 +168,23 @@ class AutomationDetails extends PureComponent { | |||
| return appActivities.map((content, index) => ( | |||
| <div key={index}> | |||
| <div className="automation-content"> | |||
| <div className="content-row name">{content[contentData]}</div> | |||
There was a problem hiding this comment.
Replacing this line with the renderProjectTag method causes the first column of the other tabs to be empty as this is what renders their content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
ESA-APIis not returning theproject-nameand allprojects-IDsare null. This PR partly corrects that issue by filling the project fields withN/Ain the Noko model at the front-end just as shown in the screenshot below.How should this be manually tested?
yarnin the frontend to install new dependencies.yarn startAny background context you want to provide?
The
Noko project tag fieldwas not being populated by any values, this was due to back-end issues with theNoko-API.What are the relevant pivotal tracker stories?
#167294842
Postman Documentation
N/A
Screenshots (If applicable)