Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft increase timeoutgrace 158174592 #26

Open
wants to merge 49 commits into
base: develop
Choose a base branch
from

Conversation

archbishop12
Copy link
Contributor

@archbishop12 archbishop12 commented Jul 12, 2018

Status

**IN DEVELOPMENT **

Migrations

NO

Description

Users will be able to select periods and grace values of upto 90 days/3months.

Related PRs

None

Todos

  • Views
  • Checks Ui/js

Deploy Notes

Run ./manage.py rumserver

Steps to Test or Reproduce

git pull
git checkout ft-increase-timeoutgrace-158174592
/manage.py rumserver

Impacted Areas in Application

  • /checks/
  • Front/views

Snapshots
screen shot 2018-07-12 at 20 28 42

Wagubi Brian added 30 commits June 22, 2018 12:21
'50%': [604800, 86400],
'66%': [2592000, 86400],
'83%': [5184000, 86400],
'max': 7776000,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and simple implementation

@EdwinKato
Copy link
Contributor

@archbishop12 Resolve conflicts.

@EdwinKato
Copy link
Contributor

@archbishop12 resolve conflicts. Kindly also reformat your PR description to follow our new template. Consult with @magicmarie on what to add under Steps to Test or Reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants