-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft increase timeoutgrace 158174592 #26
Open
archbishop12
wants to merge
49
commits into
develop
Choose a base branch
from
ft-increase-timeoutgrace-158174592
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of webhook when check is removed
matthewacha
reviewed
Jul 16, 2018
'50%': [604800, 86400], | ||
'66%': [2592000, 86400], | ||
'83%': [5184000, 86400], | ||
'max': 7776000, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and simple implementation
@archbishop12 Resolve conflicts. |
@archbishop12 resolve conflicts. Kindly also reformat your PR description to follow our new template. Consult with @magicmarie on what to add under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
**IN DEVELOPMENT **
Migrations
NO
Description
Users will be able to select periods and grace values of upto 90 days/3months.
Related PRs
None
Todos
Deploy Notes
Run ./manage.py rumserver
Steps to Test or Reproduce
git pull
git checkout ft-increase-timeoutgrace-158174592
/manage.py rumserver
Impacted Areas in Application
Snapshots