call_consensus_pileup.h: fix build failure with Gcc 12 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Gcc 12, C string header has been removed from most standard C++ includes. This causes the following build error, initially reported in Debian [Bug#1012952]: call_consensus_pileup.cpp:138:3: error: ‘strcpy’ was not declared in this scope Bringing back manually one of `cstring` or `string.h` inside the header `call_consensus_pileup.h` fixes the issue. The [original patch] brought in Debian applies to ivar release 1.3.1 to correct the following symptom, but apparently the master branch diverged from the release, so the `delete[] files` fixing the issue below may not be needed, but I mention it anyway, just in case this were to be of interest: ivar.cpp:487:14: error: ‘void operator delete(void*)’ called on pointer returned from a mismatched allocation function [-Werror=mismatched-new-delete] 487 | delete files; | ^~~~~ ivar.cpp:467:33: note: returned from ‘void* operator new [](std::size_t)’ 467 | char **files = new char*[100]; | ^ [Bug#1012952]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012952 [original patch]: https://sources.debian.org/src/ivar/1.3.1%2Bdfsg-5/debian/patches/gcc-12.patch/ Signed-off-by: Étienne Mollier <emollier@debian.org>
|
thanks for the contribution! |
This was referenced Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Gcc 12, C string header has been removed from most standard C++
includes. This causes the following build error, initially reported
in Debian Bug#1012952:
Bringing back manually one of
cstringorstring.hinside theheader
call_consensus_pileup.hfixes the issue.The original patch brought in Debian applies to ivar release 1.3.1
to correct the following symptom, but apparently the master branch
diverged from the release, so the
delete[] filesfixing the issuebelow may not be needed, but I mention it anyway, just in case this
were to be of interest:
Signed-off-by: Étienne Mollier emollier@debian.org