This repository has been archived by the owner on Jul 11, 2024. It is now read-only.
chore: Remove unused methods #516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you have two pull request that does the same ish. Is there a need for me to review both? |
the other one fixes warnings that don't involve unused code, this one actually removes unused code. |
|
Yes, I don't think you need 2 pull requests for this. Could you merge them into one? |
how do i do that? |
i closed the other pr, so just merge this one and i can add the stuff in the other pr next |
|
github actions are failing btw |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry anders, I forgot to pull before i started working, so there are 2 commits.
Description
Breaking Change?
no
Benchmarks
Checklist: