Skip to content

Commit

Permalink
cloud_storage/async_manifest_view: remove redundant call to in_stm
Browse files Browse the repository at this point in the history
prev if block is a bouncer condition in the form if(is_stm(q)) so it's
assured (!in_stm(q))

(cherry picked from commit ecc24d2)
  • Loading branch information
andijcr committed Jan 26, 2024
1 parent b34c114 commit 399406b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/v/cloud_storage/async_manifest_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1297,8 +1297,9 @@ async_manifest_view::get_materialized_manifest(
// Fast path for STM reads
co_return std::ref(_stm_manifest);
}
// query in not in the stm region
if (
!in_stm(q) && std::holds_alternative<model::timestamp>(q)
std::holds_alternative<model::timestamp>(q)
&& _stm_manifest.get_archive_start_offset() == model::offset{}) {
vlog(_ctxlog.debug, "Using STM manifest for timequery {}", q);
co_return std::ref(_stm_manifest);
Expand Down

0 comments on commit 399406b

Please sign in to comment.