Skip to content

Commit

Permalink
Go review (std-uritemplate#55)
Browse files Browse the repository at this point in the history
* fix the style issues

* Fix iteration on runes and more

* minor

* Apply golangci

* more review comments

* go - review - Mod -> rune

* use type alias

* mark go reviewed
  • Loading branch information
andreaTP authored Sep 1, 2023
1 parent a022d6a commit 72475c1
Show file tree
Hide file tree
Showing 3 changed files with 197 additions and 135 deletions.
2 changes: 1 addition & 1 deletion Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ This is intended to become a complete and maintained cross-language implementati
| Java ||||
| Python ||||
| Typescript ||||
| Go || ||
| Go || ||
| C# ||||
| Ruby ||||
| PHP ||||
Expand Down
70 changes: 70 additions & 0 deletions go/.golangci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
# ---------------------------------------------------------------------------
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# ---------------------------------------------------------------------------

linters-settings:
lll:
line-length: 170
goconst:
ignore-tests: true
linters:
enable-all: true
disable:
- forcetypeassert
- cyclop
- dupl
- exhaustive
- exhaustivestruct
- exhaustruct
- forbidigo
- funlen
- gci
- gochecknoglobals
- gochecknoinits
- gocognit
- goconst
- gocyclo
- godox
- goerr113
- gofumpt
- golint
- gomnd
- gomoddirectives
- interfacer
- ireturn
- lll
- maligned
- nakedret
- nestif
- nilnil
- nlreturn
- nosnakecase
- paralleltest
- rowserrcheck
- scopelint
- structcheck
- sqlclosecheck
- tagliatelle
- tenv
- testpackage
- varnamelen
- wastedassign
- whitespace
- wrapcheck
- wsl
- varcheck
- deadcode
- ifshort
Loading

0 comments on commit 72475c1

Please sign in to comment.