Fixed #518: Support for co_await
in a VarDecl
and more.
#542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue uncovered more shortcomings in the coroutine transformation.
a) It appears that
operator co_await
is the only operator so farwhich must have a space between "operator" and the operator name.
b) Since
co_await
is an expression the keyword can occur in a lot ofplaces, like lambdas. One limitation over lambdas is that a
co_await
occurs only in aCoroutineBodyStmt
.This patch adds support for more case, however, some are of these
transformations lead to code that is not logically correct. For
example, all loop related statements with a
co_await
as a conditionor increment expression are logically incorrect and I don't know a
way to make them correct.