-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nested lxc test to fully test the lxc_ssh.py plugin from ssh to lxc #40
Add nested lxc test to fully test the lxc_ssh.py plugin from ssh to lxc #40
Conversation
is there any reason to have this test ? ansible-lxc-ssh/tests/test-lxc_ssh.yml Lines 50 to 94 in 3e378a4
Since asible_user is by default root when you attach lxc. So become: yes / become: yes should not have any different effect here
|
I'm not sure. Does |
nope nothing since the default container user is root when you exec commands with lxc . I'm not yet sure if |
Well, I'm happy to remove it or leave it in for future use. |
Co-authored-by: David Parrish <daveparrish@tutanota.com> Co-authored-by: AnvithLobo <64419387+AnvithLobo@users.noreply.github.com>
I removed the |
@dmp1ce All the new tests are failing with ssh key problem. |
Add nested lxc test thanks to the work of @AnvithLobo. This should fully test the lxc_ssh.py plugin.
I'm not sure the previous tests were testing lxc_ssh.py at all to be honest.