Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Sound Quality" inside the options menu. #314

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

drHyperion451
Copy link

@drHyperion451 drHyperion451 commented Apr 25, 2024

This add a "Sound Quality" option that lets the user change between original quality and remastered quality setting by chnaging the sndspeed cvar. This solves #169

Also I think it's okay to add a third option named "Custom" if the user adds another value to sndspeed directy to the console, or maybe think about other options. Having a quick look to the code it seems it only checks if the value is 11025 or not, so it shouldn't really matter.

Maybe this is not a necessary change. I think it's a good QoL if I want to choose the KexQuake sound quality instead of the old one, but I leave this up to the maintainers.

Maybe it's good to add a "lock" option when the game is set to original, since this option is useless in this scenario. We should not lock sndspeed though because of mod support.

This option should change the sample rate to 44.1kHz instead of the original.
@drHyperion451 drHyperion451 marked this pull request as ready for review April 26, 2024 00:03
@drHyperion451 drHyperion451 changed the title Add the Sound Quality option. Add "Sound Quality" inside the options menu. Apr 26, 2024
@L-P
Copy link

L-P commented Jul 31, 2024

sndspeed sole purpose is to apply a low-pass filter on everything when sndspeed.value == 11025 && snd_mixspeed->value == 44100. It does nothing else.

I recommend removing the cvar and the low-pass (or at least make it optional behind another snd_lowpass) rather than adding a misleading option to the menu.

snd_mixspeed is the one controlling the SDL audio device output format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants