Add "Sound Quality" inside the options menu. #314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a "Sound Quality" option that lets the user change between original quality and remastered quality setting by chnaging the
sndspeed
cvar. This solves #169Also I think it's okay to add a third option named "Custom" if the user adds another value to
sndspeed
directy to the console, or maybe think about other options. Having a quick look to the code it seems it only checks if the value is 11025 or not, so it shouldn't really matter.Maybe this is not a necessary change. I think it's a good QoL if I want to choose the KexQuake sound quality instead of the old one, but I leave this up to the maintainers.
Maybe it's good to add a "lock" option when the game is set to original, since this option is useless in this scenario. We should not lock sndspeed though because of mod support.