Make runtime the main module #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
import { program } from 'raj/runtime'is nowimport { runtime } from 'raj'.Historically, Raj had many modules but those were pulled out into their own packages (
raj-compose,tagmeme). For quite awhile the only module has beenruntime. I personally have been trolled by having a uselessindex.jsfile for this long and want to make this break before 1.0 as it is pure cruft.This will break a few packages but the change is only a import change + find/replace.
The name "runtime" is also much better as "program" is the
{init, update, view, done}structure and it is confusing to conflate those two. A program is inert. In Elm, a "program" is something that takes those arguments but in Raj it is an application unit.