-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PartitonKey In update/Delete queries #60
Conversation
Hey this looks good.. a few suggestions that would speed up merging:
You can copy the existing integration test file and add partition keys for those operations. It would be great if they also covered correct handling of a non-happy scenario (for example, excluding a required value or passing an invalid value). These test run locally using the Vercel local CosmosDb-Server so you should easily be able to run them using npm test.
I don't think you changed anything in these so this keeps the PR cleaner and less worry that anything broke by mistake.. I'll update those in a separate PR (you can probably see I'm a bit behind on catching up on dependancies.. I need to get to that soon) With these two things, I think we'd be in good shape to merge. Thanks for taking the time to submit this! |
…roduction-Ready
…roduction-Ready
Alright I have updated the PR to add more testing infrastructure and PR comments |
Currently, Updates/deletes only work if the partionkey and the id are the same value. This change will now respect the requestOptions.partitionKey optional value
https://docs.microsoft.com/en-us/javascript/api/%40azure/cosmos/feedoptions?view=azure-node-latest#partitionKey