Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Stdlib.Pervasives deprecation #36

Merged
merged 1 commit into from Dec 3, 2019
Merged

Fix Stdlib.Pervasives deprecation #36

merged 1 commit into from Dec 3, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 28, 2019

No description provided.

@ghost
Copy link
Author

ghost commented Nov 28, 2019

If you decide to use stdlib_shims, we'd modify the jbuilder file, which wouldn't exist any longer after the migration to dune (#35). In that case, this diff would need to be adjusted and merged after #35.

@ghost
Copy link
Author

ghost commented Nov 28, 2019

Perhaps this is the wrong approach and will break more than it solves.

@rgrinberg
Copy link
Collaborator

I think this is the right approach. 4.07 isn't so new and users are welcome to use the old version.

@rgrinberg rgrinberg merged commit ea7274e into andrenth:master Dec 3, 2019
rgrinberg added a commit to rgrinberg/opam-repository that referenced this pull request Dec 3, 2019
@rgrinberg
[new release] stdint (0.6.0)
3d93212 
CHANGES:

* Speed up generic comparison of int backed types (andrenth/ocaml-stdint#34, @rixed)
* Port to dune (andrenth/ocaml-stdint#35, @Tuncer)
* Move to stdlib from pervasives (andrenth/ocaml-stdint#36, @Tuncer)
@rgrinberg rgrinberg mentioned this pull request Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rgrinberg