Fix conversion from any ints to uint24 and int24 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int24 was wrong on 64bits arch only, whereas uint24 was wrong for all archs. Before: # Uint24.(of_uint32 (Uint32.of_int 42) |> to_int);; - : int = 10752 # Int24.(of_int32 (Int32.of_int 42) |> to_int);; - : int = 10752 After: # Uint24.(of_uint32 (Uint32.of_int 42) |> to_int);; - : int = 42 # Uint24.(of_uint32 (Uint32.of_int 42) |> to_int);; - : int = 42 Closes andrenth#40 (cherry picked from commit 142ce47)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Oct 28, 2020
CHANGES: ## Fixes: * Correct conversion from uint24 to other ints (andrenth/ocaml-stdint#39, @rixed) * Fix conversion from all ints to uint24 and int24 (andrenth/ocaml-stdint#41, @rixed) * Fix int24 failing to recover from casts (andrenth/ocaml-stdint#43, @rixed) * Fix sign extensions (andrenth/ocaml-stdint#49, @rixed) * `Long_val` returns `intnat`, previously `long` was used (andrenth/ocaml-stdint#53, @dra27) * Reduce size of marshalled custom values on 4.08+ (andrenth/ocaml-stdint#54, @dra27) * Store 128-bit ints as structs to prevent unaligned access (andrenth/ocaml-stdint#55, @dra27) ## New features: * Add `of_substring` (andrenth/ocaml-stdint#49, @darlentar)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Oct 28, 2020
CHANGES: ## Fixes: * Correct conversion from uint24 to other ints (andrenth/ocaml-stdint#39, @rixed) * Fix conversion from all ints to uint24 and int24 (andrenth/ocaml-stdint#41, @rixed) * Fix int24 failing to recover from casts (andrenth/ocaml-stdint#43, @rixed) * Fix sign extensions (andrenth/ocaml-stdint#49, @rixed) * `Long_val` returns `intnat`, previously `long` was used (andrenth/ocaml-stdint#53, @dra27) * Reduce size of marshalled custom values on 4.08+ (andrenth/ocaml-stdint#54, @dra27) * Store 128-bit ints as structs to prevent unaligned access (andrenth/ocaml-stdint#55, @dra27) ## New features: * Add `of_substring` (andrenth/ocaml-stdint#49, @darlentar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int24 was wrong on 64bits arch only, whereas uint24 was wrong for all
archs.
NOTICE: this fix assumes that the previous fix re. uint24 is merged already. Otherwise, conversion to uint24 are still bogus (although less so).
Before:
After:
Closes #40
(cherry picked from commit 142ce47)