Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply changes to .pre-commit-config.yaml #282

Closed
6 tasks done
andreoliwa opened this issue Feb 13, 2021 · 1 comment · Fixed by #434
Closed
6 tasks done

Apply changes to .pre-commit-config.yaml #282

andreoliwa opened this issue Feb 13, 2021 · 1 comment · Fixed by #434
Labels
enhancement New feature or request plugin-pre-commit Plugin for pre-commit hooks released Feature/fix is released
Milestone
Apply suggestions...

Comments

@andreoliwa
Copy link
Owner

andreoliwa commented Feb 13, 2021 •
edited
Loading

Problem

Apply suggestions to .pre-commit-config.yaml.

Possible solution

  • After finding the differences, apply them on the YAML dict
  • Save the dict as a .yaml file
  • Try not to lose the formatting or comments
  • feat(yaml): autofix .pre-commit-config.yaml
  • Slight breaking change in the TOML config format: ditching the old TOML config
  • Maybe display an error message warning about the format change? "Please update your style, repos.yaml is not supported anymore"
@andreoliwa andreoliwa added the enhancement New feature or request label Feb 13, 2021
@andreoliwa andreoliwa added the plugin-pre-commit Plugin for pre-commit hooks label Feb 13, 2021
@andreoliwa andreoliwa mentioned this issue Jan 2, 2022
Merged
14 tasks
@github-actions
Copy link

🎉 This issue has been resolved in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Jan 14, 2022
@andreoliwa andreoliwa moved this to Done in Nitpick Roadmap Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request plugin-pre-commit Plugin for pre-commit hooks released Feature/fix is released
Projects
Nitpick Roadmap
Archived in project
Milestone
Apply suggestions to configuration files
Development

Successfully merging a pull request may close this issue.

feat(yaml): autofix .pre-commit-config.yaml (note: style changed!) andreoliwa/nitpick
1 participant
@andreoliwa