Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(yaml): autofix .pre-commit-config.yaml (note: style changed!) #434

Merged
merged 33 commits into from
Jan 7, 2022
Merged

feat(yaml): autofix .pre-commit-config.yaml (note: style changed!) #434

merged 33 commits into from
Jan 7, 2022

Conversation

andreoliwa
Copy link
Owner

@andreoliwa andreoliwa commented Jan 2, 2022 •
edited
Loading

Fixes #282.

Proposed changes

  • feat(yaml): autofix .pre-commit-config.yaml (note: style changed!)
  • feat(yaml): special config: unique keys to search elements in lists
  • style: add autoflake
  • style: add prettier
  • style: deprecate old pre-commit style for repos ("repos.yaml" key)
  • style: update all styles with new pre-commit format

Checklist

  • Read the contribution guidelines
  • Run make locally before pushing commits
  • Add tests for the relevant parts:
    • API
    • CLI
    • flake8 plugin (normal mode)
    • flake8 plugin (offline mode)
  • Write documentation when there's a new API or functionality

@andreoliwa andreoliwa changed the title feat(yaml): autofix .pre-commit-config.yaml feat(yaml): autofix .pre-commit-config.yaml (note: style changed!) Jan 2, 2022
@coveralls
Copy link

coveralls commented Jan 2, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1669453638

  • 190 of 200 (95.0%) changed or added relevant lines in 7 files are covered.
  • 15 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 95.544%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nitpick/plugins/yaml.py 66 67 98.51%
src/nitpick/documents.py 101 110 91.82%
Files with Coverage Reduction New Missed Lines %
src/nitpick/documents.py 7 87.02%
src/nitpick/style/core.py 8 84.72%
Totals Coverage Status
Change from base Build 1652745474: -0.7%
Covered Lines: 1992
Relevant Lines: 2060
💛 - Coveralls

@andreoliwa
refactor: mutable mapping
fe3f045
@andreoliwa
refactor: JsonDict everywhere
e0cc97c
@andreoliwa
refactor: JsonDict replaces JsonYaml
6fa0249
@andreoliwa
test: deprecation warning for "repos.yaml" key
240f3a9
@andreoliwa
style: remove deprecated repos.yaml key from all styles
e344dc7
@andreoliwa
docs: ideas for presence/absence of keys
506b407 
Related to:
- #218
- #10
@andreoliwa
feat(yaml): custom unique keys for fields
d79cdf0
@andreoliwa
docs: more comments
29c54a4
@andreoliwa
docs: more small fixes
00171b8
@andreoliwa
docs: ReadTheDocs still didn't upgrade to Python 3.9
f25badb
@andreoliwa
Merge branch 'develop' into autofix-pre-commit-config
24c2710
@andreoliwa
test: overriding the default unique key with nothing
23020dd
@andreoliwa
Merge remote-tracking branch 'origin/autofix-pre-commit-config' into …
ac5673e 
…autofix-pre-commit-config
@andreoliwa
test: overriding unique keys
6d1b495
@andreoliwa
Merge branch 'develop' into autofix-pre-commit-config
494bf51
@andreoliwa
test: when the key already exists, don't show diff (complex case)
9de6003
@andreoliwa
docs: maybe a way to compare elements
13cb0b9
@andreoliwa
feat: compare elements individually
7bd27b0
@andreoliwa
refactor: slightly reduce complexity (not ideal yet)
a5a3da6
@andreoliwa
docs: remember to test more cases
3947382
@andreoliwa
docs: more cases... this will never end
1bce0b1
@andreoliwa
test: nested dict with different key/value pairs
357ce8e
@andreoliwa andreoliwa marked this pull request as ready for review January 7, 2022 21:37
@andreoliwa andreoliwa merged commit 352b53d into develop Jan 7, 2022
@andreoliwa andreoliwa deleted the autofix-pre-commit-config branch January 7, 2022 22:10
github-actions bot pushed a commit that referenced this pull request Jan 14, 2022
@semantic-release-bot
chore(release): 0.30.0 [skip ci]
8a1d2bd 
# [0.30.0](v0.29.0...v0.30.0) (2022-01-14)

### Bug Fixes

* style override on Windows ([#422](#422)) ([e7d2897](e7d2897))
* use current dir; don't climb dirs to find the project root ([#421](#421)) ([3c82e8c](3c82e8c))

### Features

* default pre-commit hook now runs "nitpick fix" ([cb4c242](cb4c242))
* **json:** autofix JSON files ([#429](#429)) ([4b58a03](4b58a03))
* nitpick init adds a [tool.nitpick] section ([36f4065](36f4065))
* **yaml:** autofix .pre-commit-config.yaml (note: style changed!) ([#434](#434)) ([352b53d](352b53d))
* **yaml:** autofix GitHub Workflow files ([#437](#437)) ([6af77c4](6af77c4))
* **yaml:** autofix YAML files ([#431](#431)) ([d8cc4b1](d8cc4b1))
@github-actions
Copy link

🎉 This PR is included in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Feature/fix is released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply changes to .pre-commit-config.yaml
2 participants
@andreoliwa @coveralls