Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature-02-add-orders-endpoints #10

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

feature-02-add-orders-endpoints #10

wants to merge 4 commits into from

Conversation

andresWeitzel
Copy link
Owner

@andresWeitzel andresWeitzel commented Oct 24, 2023 •
edited
Loading

Pending task

  • Completar todas las funcionalidades para orders
  • La actualizacion de una orden no funciona
  • Modificar nombres de const statusCodeInternalServerError para convencionales
  • Mejorar switch y logica de respuesta para controladores
  • Agregar logica de validacion de axios para los services (si obtenemos valores vacíos debemos tratarlos)

@andresWeitzel andresWeitzel added the enhancement New feature or request label Oct 24, 2023
@andresWeitzel andresWeitzel self-assigned this Oct 24, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 4, 2023
View reviewed changes
src/config/routes/orders-routes.ts
ordersRouter.post("/confirm/:id", confirmOrderController);

//For review
ordersRouter.post("/authorize-payment/:id", authorizePaymentOrderController);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andresWeitzel andresWeitzel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andresWeitzel