Skip to content

Commit

Permalink
Additional cstyle fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
lundman authored and andrewc12 committed Aug 26, 2022
1 parent fd3a1dd commit 6156801
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 13 deletions.
2 changes: 1 addition & 1 deletion include/os/windows/spl/sys/linker_set.h
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
*/
#define TEXT_SET(set, sym) __MAKE_SET(set, sym)
#define DATA_SET(set, sym) __MAKE_SET(set, sym)
#define DATA_WSET(set, sym) __MAKE_SET_QV(set, sym,)
#define DATA_WSET(set, sym) __MAKE_SET_QV(set, sym, /* */)
#define BSS_SET(set, sym) __MAKE_SET(set, sym)
#define ABS_SET(set, sym) __MAKE_SET(set, sym)
#define SET_ENTRY(set, sym) __MAKE_SET(set, sym)
Expand Down
2 changes: 0 additions & 2 deletions lib/libspl/include/os/windows/string.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
#ifndef _LIBSPL_WINDOWS_STRING_H
#define _LIBSPL_WINDOWS_STRING_H

#pragma message("this we want")

#include_next <string.h>

static inline char *
Expand Down
4 changes: 2 additions & 2 deletions lib/libspl/os/windows/posix.c
Original file line number Diff line number Diff line change
Expand Up @@ -927,7 +927,7 @@ wosix_open(const char *inpath, int oflag, ...)

h = CreateFile(path, mode, share, NULL, how,
oflag & O_DIRECTORY ? FILE_FLAG_BACKUP_SEMANTICS : \
FILE_ATTRIBUTE_NORMAL,
FILE_ATTRIBUTE_NORMAL,
NULL);

// Could be a directory (but we come from stat so no O_DIRECTORY)
Expand All @@ -947,7 +947,7 @@ wosix_open(const char *inpath, int oflag, ...)

h = CreateFile(end, mode, share, NULL, how,
oflag & O_DIRECTORY ? FILE_FLAG_BACKUP_SEMANTICS : \
FILE_ATTRIBUTE_NORMAL,
FILE_ATTRIBUTE_NORMAL,
NULL);
if (h != INVALID_HANDLE_VALUE) {
// Upper layer probably handles this, but let's help
Expand Down
2 changes: 1 addition & 1 deletion module/os/windows/zfs/zfs_vnops_os.c
Original file line number Diff line number Diff line change
Expand Up @@ -1845,7 +1845,7 @@ zfs_readdir(vnode_t *vp, zfs_uio_t *uio, cred_t *cr, zfs_dirlist_t *zccb,
eodp =
(FILE_FULL_DIR_INFORMATION *)bufptr;
FILE_ID_EXTD_BOTH_DIR_INFORMATION
*fiebdi;
*fiebdi;
fiebdi =
(FILE_ID_EXTD_BOTH_DIR_INFORMATION
*)bufptr;
Expand Down
4 changes: 2 additions & 2 deletions module/os/windows/zfs/zfs_vnops_windows.c
Original file line number Diff line number Diff line change
Expand Up @@ -3110,8 +3110,8 @@ request_oplock(PDEVICE_OBJECT DeviceObject, PIRP *PIrp,
&vp->FileHeader.AllocationSize);
else if
(fFsRtlAreThereCurrentOrInProgressFileLocks)
oplock_count =
fFsRtlAreThereCurrentOrInProgressFileLocks(&vp->lock);
oplock_count =
fFsRtlAreThereCurrentOrInProgressFileLocks(&vp->lock);
else
oplock_count =
FsRtlAreThereCurrentFileLocks(&vp->
Expand Down
9 changes: 4 additions & 5 deletions module/os/windows/zfs/zfs_windows_zvol_wmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -783,18 +783,17 @@ ExecuteWmiMethod(
PGetDiscoveredPortAttributes_OUT pOut =
(PGetDiscoveredPortAttributes_OUT)
pBuffer;
sizeNeeded =
GetDiscoveredPortAttributes_OUT_SIZE;
sizeNeeded =
GetDiscoveredPortAttributes_OUT_SIZE;

if (OutBufferSize >= sizeNeeded) {
memset(pOut, 0, sizeNeeded);

// since this is a virtual
// driver with no discovered
// ports,always return an error
pOut->
HBAStatus =
HBA_STATUS_ERROR_ILLEGAL_INDEX;
pOut->HBAStatus =
HBA_STATUS_ERROR_ILLEGAL_INDEX;
} else {
status =
SRB_STATUS_DATA_OVERRUN;
Expand Down

0 comments on commit 6156801

Please sign in to comment.