Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Project.toml and remove Nullable dependency #33

Merged
merged 15 commits into from
Jul 10, 2021

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Nov 26, 2019

This package is required by GraphIO.jl, so I'm refreshing it to work on current Julia versions (1.x):

  • replace Nullable{T} with Union{T, Nothing} and drop Nullable.jl dependency
  • replace REQUIRE with Project.toml (using gen_project.jl) script

It also makes sense to set up @JuliaRegistrator and @JuliaTagBot for the repository.

@coveralls
Copy link

coveralls commented Nov 26, 2019

Coverage Status

Coverage decreased (-8.2%) to 85.017% when pulling a80b50d on alyst:remove_nullable into 1b384cc on andrewcooke:master.

@alyst
Copy link
Contributor Author

alyst commented Mar 12, 2020

Bump :)
I might do a few other touches to this PR (in particular, to improve the coverage), but it would be nice to know whether the merging would be possible in principle.

@CarloLucibello
Copy link
Collaborator

Hi, I can merge your PR but probably I don't have permissions to activate registrator/tagbot and @andrewcooke is awol. We could merge this when you are ready and then fork if needed

@alyst
Copy link
Contributor Author

alyst commented Mar 12, 2020

I think it's ready for review. The coverage fell, but the tests didn't change. So it looks that's because the identification of coverable lines has changed.

@alyst alyst force-pushed the remove_nullable branch from 66a36a1 to 128f17e Compare July 10, 2021 12:26
@alyst alyst force-pushed the remove_nullable branch from 128f17e to 6703d6e Compare July 10, 2021 12:28
@alyst
Copy link
Contributor Author

alyst commented Jul 10, 2021

I've rebased the branch against the current master, updated GitHub actions and switched to GitHub CI. Would be nice to merge :)

@CarloLucibello CarloLucibello merged commit cf60b5e into andrewcooke:master Jul 10, 2021
@alyst alyst mentioned this pull request Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants