-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Project.toml and remove Nullable dependency #33
Conversation
1cc1579
to
a80b50d
Compare
Bump :) |
Hi, I can merge your PR but probably I don't have permissions to activate registrator/tagbot and @andrewcooke is awol. We could merge this when you are ready and then fork if needed |
I think it's ready for review. The coverage fell, but the tests didn't change. So it looks that's because the identification of coverable lines has changed. |
drop Nullable package dependency
it was there due to 0.3 limitation
so that one ctor calls the lower-level one (to minimize typos)
to make it compatible with CompatHelper
I've rebased the branch against the current master, updated GitHub actions and switched to GitHub CI. Would be nice to merge :) |
This package is required by GraphIO.jl, so I'm refreshing it to work on current Julia versions (1.x):
Nullable{T}
withUnion{T, Nothing}
and drop Nullable.jl dependencyIt also makes sense to set up @JuliaRegistrator and @JuliaTagBot for the repository.