Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe now uses "Sources" instead of "Cards" #155

Open
j-mcnally opened this issue Mar 20, 2016 · 2 comments
Open

Stripe now uses "Sources" instead of "Cards" #155

j-mcnally opened this issue Mar 20, 2016 · 2 comments

Comments

@j-mcnally
Copy link

Needs to change references of "cards" to "sources" and "default_card" to "default_source"

@yas4891
Copy link
Collaborator

yas4891 commented Mar 20, 2016

Hi Justin,

I know, but sadly there is much more to it than just switching attribute names. That's only the very quick fix.
When we make the move we'll have to address differences between CC and ACH.

@j-mcnally
Copy link
Author

Ok, @yas4891, i was able to fix it for my use case atleast to support credit cards in my PR.

Sadly, when i was using the koudoku today, without this fix, it did not work at all.

I would suggest accepting the PR in the interim until you can figure out how to handle ACH.

durfee added a commit to durfee/koudoku that referenced this issue Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants