fix: mark PIDFDInfo and PIDRUsage unsafe #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanpailes
force-pushed
the
mark-traits-unsafe
branch
from
349d050
to
e891e2d
Compare
|
Clippy fails due to missing docs for UNSAFE |
|
Fixes #146 |
ethanpailes
force-pushed
the
mark-traits-unsafe
branch
3 times, most recently
from
5f5f3e0
to
e2b7527
Compare
|
The test failures should be fixed now. Sorry it took a minute, I had notifications routing to the wrong email. |
ethanpailes
force-pushed
the
mark-traits-unsafe
branch
3 times, most recently
from
2b17758
to
3e42c03
Compare
This patch marks the PIDRUsage and PIDFDInfo traits as unsafe, since incorrect implementations of these traits could lead to unsound behavior. Unfortunately, since these are public traits, this will mean an incompatible version bump for the next release, though hopefully no one is really rolling their own implementation for these guys. https://doc.rust-lang.org/reference/unsafe-keyword.html#unsafe-traits-unsafe-trait
ethanpailes
force-pushed
the
mark-traits-unsafe
branch
from
3e42c03
to
b7d306b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch marks the PIDRUsage and PIDFDInfo traits as unsafe, since incorrect implementations of
these traits could lead to unsound behavior.
Unfortunately, since these are public traits,
this will mean an incompatible version bump
for the next release, though hopefully no one
is really rolling their own implementation for
these guys.
https://doc.rust-lang.org/reference/unsafe-keyword.html#unsafe-traits-unsafe-trait