Additional numpy __array_function__ implementations #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction tests Adds a decorator so that numpy function tests are skipped when the __array_function__ protocol is not enabled. Adds tests for the following numpy functions operating through the __array_function__ protocol: - argmax - argmin - argsort - max - min - nanmax - nanmin - ones_like - shape - zeros_like
This commit adds the following the functions via implement_func, with tests: alen append around average clip copy count_nonzero cumprod cumproduct cumsum diagonal dot flip mean median nanargmax nanargmin nancumprod nancumsum nanmean nanmedian nan_to_num nanstd nansum nanvar ndim nonzero ptp ravel result_type round_ sort std sum transpose trim_zeros var
This was referenced Aug 22, 2019
This was referenced Aug 28, 2019
This was referenced Sep 12, 2019
|
For later reference when this is likely re-implemented, see important commentary regarding Also, I think part of the original |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in hgrecco#764, here is a PR adding a bunch of additional numpy functions with tests.
Also, I made a few other changes that I hoped would be okay...let me know if you are okay with merging them or if I should rebase any of them out:
__array_function__to work, since it is not a guarantee it will be active__array_function__protocol being active (since the warning seems invalid if it isn't)