Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with the name resolution changes in the previous release #127

Merged
merged 6 commits into from
Sep 8, 2024

Conversation

andrewhickman
Copy link
Owner

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.24%. Comparing base (4c8c56b) to head (94707a3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
prost-reflect/src/descriptor/mod.rs 45.45% 6 Missing ⚠️
prost-reflect/src/descriptor/build/mod.rs 85.18% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   76.24%   76.24%           
=======================================
  Files          31       31           
  Lines        5456     5473   +17     
=======================================
+ Hits         4160     4173   +13     
- Misses       1296     1300    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewhickman andrewhickman merged commit f90733b into main Sep 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shadowing error when field names matches package
1 participant